[
https://issues.apache.org/jira/browse/KAFKA-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-8784:
------------------------------------------
Description:
In 2.3 we added a new method to RocksDBConfigSetter that will be called when a
store is closed to clean up any resources that may have been created in
#setConfig. Many large objects such as the block cache might be instantiated in
that method, which will leak memory if not closed since they are backed by C++
objects.
We should consider removing the default implementation to force users to pay
attention to whether they may be leaking memory, even if it may be a no-op for
many. Remember to update the upgrade guide when we do so to maintain a clear
list of the breaking changes in 3.0
was:
In 2.3 we added a new method to RocksDBConfigSetter that will be called when a
store is closed to clean up any resources that may have been created in
#setConfig. Many large objects such as the block cache might be instantiated in
that method, which will leak memory if not closed since they are backed by C++
objects.
We should consider removing the default implementation to force users to pay
attention to whether they may be leaking memory, even if it may be a no-op for
many.
> Remove default implementation of RocksDBConfigSetter#close
> ----------------------------------------------------------
>
> Key: KAFKA-8784
> URL: https://issues.apache.org/jira/browse/KAFKA-8784
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Reporter: A. Sophie Blee-Goldman
> Assignee: Walker Carlson
> Priority: Blocker
> Fix For: 3.0.0
>
>
> In 2.3 we added a new method to RocksDBConfigSetter that will be called when
> a store is closed to clean up any resources that may have been created in
> #setConfig. Many large objects such as the block cache might be instantiated
> in that method, which will leak memory if not closed since they are backed by
> C++ objects.
> We should consider removing the default implementation to force users to pay
> attention to whether they may be leaking memory, even if it may be a no-op
> for many. Remember to update the upgrade guide when we do so to maintain a
> clear list of the breaking changes in 3.0
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
