ijuma commented on a change in pull request #10389:
URL: https://github.com/apache/kafka/pull/10389#discussion_r602220116
##########
File path: core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala
##########
@@ -154,7 +160,10 @@ class ListOffsetsRequestTest extends BaseRequestTest {
@Test
def testResponseIncludesLeaderEpoch(): Unit = {
- val partitionToLeader = TestUtils.createTopic(zkClient, topic,
numPartitions = 1, replicationFactor = 3, servers)
+ val topicConfig = new Properties
+ // make sure we won't lose data when force-removing leader
+ topicConfig.setProperty(TopicConfig.MIN_IN_SYNC_REPLICAS_CONFIG, "2")
Review comment:
Is this required? Even with min isr 1, we still require all in sync
replicas to ack for acks=all. How many brokers do we have in the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
