[GitHub] [kafka] jolshan commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

[GitBox]

jolshan commented on a change in pull request #10282:
URL: https://github.com/apache/kafka/pull/10282#discussion_r594553183



##########
File path: 
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/server/CheckpointBench.java
##########
@@ -145,7 +145,7 @@ public void setup() {
         OffsetCheckpoints checkpoints = (logDir, topicPartition) -> 
Option.apply(0L);
         for (TopicPartition topicPartition : topicPartitions) {
             final Partition partition = 
this.replicaManager.createPartition(topicPartition);
-            partition.createLogIfNotExists(true, false, checkpoints);
+            partition.createLogIfNotExists(true, false, checkpoints, 
Option.empty());

Review comment:
       I think we can just not set the topic ID here, but want to confirm.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org