MarcoLotz commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r588864401
##########
File path: build.gradle
##########
@@ -1416,14 +1416,6 @@ project(':streams') {
dependencies {
api project(':clients')
- // use `api` dependency for `connect-json` for compatibility (e.g. users
who use `JsonSerializer`/`JsonDeserializer`
- // at compile-time without an explicit dependency on `connect-json`)
- // this dependency should be removed after we unify data API
- api(project(':connect:json')) {
- // this transitive dependency is not used in Streams, and it breaks SBT
builds
- exclude module: 'javax.ws.rs-api'
- }
-
implementation libs.slf4jApi
implementation libs.rocksDBJni
implementation libs.jacksonAnnotations
Review comment:
"implementation libs.jacksonDatabind" is already being added to
compileClassPath in streams module.
Thus it seems that indeed there's no need to add compile dependency of
libs.jacksonDatabind to streams module. Please let me know if this is not the
case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
