cmccabe commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r585942960
##########
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##########
@@ -809,6 +824,27 @@ private QuorumController(LogContext logContext,
() -> replicationControl.unregisterBroker(brokerId));
}
+ @Override
+ public CompletableFuture<Map<String, ResultOrError<Uuid>>>
findTopicIds(Collection<String> names) {
+ if (names.isEmpty()) return
CompletableFuture.completedFuture(Collections.emptyMap());
+ return appendReadEvent("findTopicIds",
+ () -> replicationControl.findTopicIds(lastCommittedOffset, names));
+ }
+
+ @Override
+ public CompletableFuture<Map<Uuid, ResultOrError<String>>>
findTopicNames(Collection<Uuid> ids) {
+ if (ids.isEmpty()) return
CompletableFuture.completedFuture(Collections.emptyMap());
+ return appendReadEvent("findTopicNames",
+ () -> replicationControl.findTopicNames(lastCommittedOffset, ids));
+ }
+
+ @Override
+ public CompletableFuture<Map<Uuid, ApiError>>
deleteTopics(Collection<Uuid> ids) {
+ if (ids.isEmpty()) return
CompletableFuture.completedFuture(Collections.emptyMap());
+ return appendWriteEvent("deleteTopics",
+ () -> replicationControl.deleteTopics(ids));
Review comment:
Yes, it should be implicit based on the DeleteTopic record. I will fix
the controller to do the right thing here. We'll also need to have the broker
do that too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
