junrao commented on a change in pull request #8812:
URL: https://github.com/apache/kafka/pull/8812#discussion_r583834117
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -826,8 +832,16 @@ class Log(@volatile private var _dir: File,
preallocate = config.preallocate))
}
- recoveryPoint = activeSegment.readNextOffset
Review comment:
For the case that Tim mentioned, if we defer advancing the recovery
point, at step 5, the broker will be forced to do log recovery for all
unflushed data. If the data is corrupted on disk, it will be detected during
recovery.
For the other case that Ismael mentioned, it is true that data can be lost
in that case, but then this is the case where all replicas have failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
