C0urante commented on a change in pull request #10016:
URL: https://github.com/apache/kafka/pull/10016#discussion_r583778100
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java
##########
@@ -64,7 +64,7 @@
private final TaskMetricsGroup taskMetricsGroup;
private volatile TargetState targetState;
private volatile boolean stopping; // indicates whether the Worker has
asked the task to stop
- private volatile boolean cancelled; // indicates whether the Worker has
cancelled the task (e.g. because of slow shutdown)
+ protected volatile boolean cancelled; // indicates whether the Worker has
cancelled the task (e.g. because of slow shutdown)
Review comment:
Mmmm, aligns nicely with the existing `WorkerTask.stopping` and
`WorkerTask::isStopping` field and method, respectively. Will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
