ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r583612163
##########
File path: build.gradle
##########
@@ -219,34 +223,43 @@ subprojects {
options.compilerArgs << "--release" << minJavaVersion
}
- uploadArchives {
- repositories {
- signing {
- required { shouldSign }
- sign configurations.archives
-
- // To test locally, replace mavenUrl in ~/.gradle/gradle.properties
to file://localhost/tmp/myRepo/
- mavenDeployer {
- beforeDeployment { MavenDeployment deployment ->
signing.signPom(deployment) }
- repository(url: "${mavenUrl}") {
- authentication(userName: "${mavenUsername}", password:
"${mavenPassword}")
- }
- afterEvaluate {
- pom.artifactId = "${archivesBaseName}"
- pom.project {
- name 'Apache Kafka'
- packaging 'jar'
- url 'https://kafka.apache.org'
- licenses {
- license {
- name 'The Apache Software License, Version 2.0'
- url
'https://www.apache.org/licenses/LICENSE-2.0.txt'
- distribution 'repo'
- }
- }
- }
+ if (shouldPublish) {
+
+ publishing {
+ repositories {
+ // To test locally, replace mavenUrl in ~/.gradle/gradle.properties to
file://localhost/tmp/myRepo/
Review comment:
Yeah, you can pass -PmavenUrl or update gradle.properties. This was an
existing comment, would you prefer if we suggest `-PmavenUrl` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
