cmccabe commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r582256432
##########
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##########
@@ -195,6 +198,61 @@ class ControllerApis(val requestChannel: RequestChannel,
requestThrottleMs => createResponseCallback(requestThrottleMs))
}
+ def handleDeleteTopics(request: RequestChannel.Request): Unit = {
+ if (!config.deleteTopicEnable) {
+ if (request.context.apiVersion() < 3) {
+ throw new InvalidRequestException("Topic deletion is disabled.")
Review comment:
As @ijuma said, in this case the error message gives extra information
which would be very helpful to users. If we always wanted the same message,
there would be no reason to have the string field in the wire protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
