cmccabe commented on a change in pull request #10070:
URL: https://github.com/apache/kafka/pull/10070#discussion_r579464755
##########
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##########
@@ -397,6 +397,9 @@ class BrokerServer(
info("shutting down")
if (config.controlledShutdownEnable) {
+ // Shut down the broker metadata listener, so that we don't get added
to any
+ // more ISRs.
+ brokerMetadataListener.beginShutdown()
Review comment:
It does need to be because there are some paths through the code that
don't go through here. In general calling `beginShutdown` or `close` multiple
times is harmless-- only the first time has an effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
