rhauch commented on a change in pull request #10158:
URL: https://github.com/apache/kafka/pull/10158#discussion_r578916881
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java
##########
@@ -390,7 +410,11 @@ public void run() {
log.trace("Finished read to end log for topic {}",
topic);
} catch (TimeoutException e) {
log.warn("Timeout while reading log to end for
topic '{}'. Retrying automatically. " +
- "This may occur when brokers are unavailable
or unreachable. Reason: {}", topic, e.getMessage());
+ "This may occur when brokers are
unavailable or unreachable. Reason: {}", topic, e.getMessage());
+ continue;
+ } catch (RetriableException |
org.apache.kafka.connect.errors.RetriableException e) {
Review comment:
The previous `readToLogEnd()` that used the consumer did not have any
special exception handling in the `start()` method. Any problem to start seems
like it should propagate up to result in the worker failing. Especially when
coupled with your fix in #10152.
I added this here because retriable exceptions should not stop the
KafkaBasedLog's thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
