hachikuji commented on a change in pull request #10063:
URL: https://github.com/apache/kafka/pull/10063#discussion_r578870321
##########
File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchBuilder.java
##########
@@ -307,4 +309,38 @@ public int writeRecord(
recordOutput.writeVarint(0);
return ByteUtils.sizeOfVarint(sizeInBytes) + sizeInBytes;
}
+
+ private int batchHeaderSizeInBytes() {
+ return AbstractRecords.recordBatchHeaderSizeInBytes(
+ RecordBatch.MAGIC_VALUE_V2,
+ compressionType
+ );
+ }
+
+ private int bytesNeededForRecords(
+ Collection<T> records,
+ ObjectSerializationCache serializationCache
+ ) {
+ long expectedNextOffset = nextOffset;
+ int bytesNeeded = 0;
+ for (T record : records) {
+ if (expectedNextOffset - baseOffset >= Integer.MAX_VALUE) {
+ return Integer.MAX_VALUE;
Review comment:
Since we are handling this case by raising an exception, is it worth
checking for overflow of `bytesNeeded` as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
