jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r572413017
##########
File path: core/src/main/scala/kafka/server/FetchSession.scala
##########
@@ -71,6 +75,7 @@ object FetchSession {
* localLogStartOffset is the log start offset of the partition on this
broker.
*/
class CachedPartition(val topic: String,
+ var topicId: Uuid,
Review comment:
I thought about this, but I was worried about some weirdness where we
need to support partitions before and after they have an id. (The partitions
are techincally equivalent, but equals wouldn't reflect that) This may also
cause problems in cases where IDs may change. Consider the code ` val
cachedPart = session.partitionMap.find(new CachedPartition(topicPart))` This
is used in the path of deleting partitions with stale IDs. We would need to
know the topic ID to find the partition here. I could see potential issues
where we no longer have the ID and would have trouble removing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
