ijuma commented on a change in pull request #10069:
URL: https://github.com/apache/kafka/pull/10069#discussion_r571453212
##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -248,19 +250,19 @@ class ReplicaManager(val config: KafkaConfig,
/* epoch of the controller that last changed the leader */
@volatile var controllerEpoch: Int = KafkaController.InitialControllerEpoch
- private val localBrokerId = config.brokerId
- private val allPartitions = new Pool[TopicPartition, HostedPartition](
+ protected val localBrokerId = config.brokerId
+ protected val allPartitions = new Pool[TopicPartition, HostedPartition](
valueFactory = Some(tp => HostedPartition.Online(Partition(tp, time,
configRepository, this)))
)
- private val replicaStateChangeLock = new Object
+ protected val replicaStateChangeLock = new Object
val replicaFetcherManager = createReplicaFetcherManager(metrics, time,
threadNamePrefix, quotaManagers.follower)
val replicaAlterLogDirsManager =
createReplicaAlterLogDirsManager(quotaManagers.alterLogDirs, brokerTopicStats)
private val highWatermarkCheckPointThreadStarted = new AtomicBoolean(false)
@volatile var highWatermarkCheckpoints: Map[String, OffsetCheckpointFile] =
logManager.liveLogDirs.map(dir =>
Review comment:
Is this intended to be public? Maybe we should fix it while we're at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
