aloknnikhil commented on a change in pull request #9996: URL: https://github.com/apache/kafka/pull/9996#discussion_r568248443
########## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ########## @@ -98,7 +98,8 @@ UPDATE_FEATURES(ApiMessageType.UPDATE_FEATURES, false, true), ENVELOPE(ApiMessageType.ENVELOPE, true, RecordBatch.MAGIC_VALUE_V0, false, true), FETCH_SNAPSHOT(ApiMessageType.FETCH_SNAPSHOT, false, RecordBatch.MAGIC_VALUE_V0, false, true), - DESCRIBE_CLUSTER(ApiMessageType.DESCRIBE_CLUSTER); + DESCRIBE_CLUSTER(ApiMessageType.DESCRIBE_CLUSTER), + DECOMMISSION_BROKER(ApiMessageType.DECOMMISSION_BROKER, false, RecordBatch.MAGIC_VALUE_V0, true, true); Review comment: Ah. Right. I'm curious, then, what would happen if we send a decommission request through the broker being decommissioned? Wouldn't the broker shutdown (as a result of being unregistered) before responding to the AdminClient call? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org