ijuma commented on a change in pull request #10008:
URL: https://github.com/apache/kafka/pull/10008#discussion_r567546097
##########
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##########
@@ -318,8 +318,9 @@ class KafkaServer(
/* start group coordinator */
// Hardcode Time.SYSTEM for now as some Streams tests fail otherwise,
it would be good to fix the underlying issue
- groupCoordinator = GroupCoordinator(config, zkClient, replicaManager,
Time.SYSTEM, metrics)
- groupCoordinator.startup()
+ groupCoordinator = GroupCoordinator(config, replicaManager,
Time.SYSTEM, metrics)
+
groupCoordinator.startup(zkClient.getTopicPartitionCount(Topic.GROUP_METADATA_TOPIC_NAME).
Review comment:
The fact that we have stuff like the following implies that the approach
taken here isn't so good:
*
https://github.com/apache/kafka/pull/10008/files#diff-8bdfc05a89875ddd25c9bd355c102ca2a0556795bb18fba25efc3f9959d789e2R199
*
https://github.com/apache/kafka/pull/10008/files#diff-8bdfc05a89875ddd25c9bd355c102ca2a0556795bb18fba25efc3f9959d789e2R188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
