jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r567188108
##########
File path: core/src/main/scala/kafka/server/FetchSession.scala
##########
@@ -187,24 +205,86 @@ class CachedPartition(val topic: String,
}
}
+/**
+ * Very similar to CachedPartition above, CachedUnresolvedPartition is used
for incremental fetch requests.
+ * These objects store partitions that had topic IDs that could not be
resolved by the broker.
+ *
+ * Upon each incremental request in the session, these partitions will be
loaded. They can either be removed
+ * through resolving the partition with the broker's topicNames map or by
receiving an unresolved toForget ID.
+ *
+ * Since these partitions signify an error, they will always be returned in
the response.
+ */
+
+class CachedUnresolvedPartition(val topicId: Uuid,
+ val partition: Int,
+ var maxBytes: Int,
+ var fetchOffset: Long,
+ var leaderEpoch: Optional[Integer],
+ var fetcherLogStartOffset: Long,
+ var lastFetchedEpoch: Optional[Integer]) {
Review comment:
We need to keep the data from the fetch request for when we resolve the
partition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
