bob-barrett commented on a change in pull request #9902:
URL: https://github.com/apache/kafka/pull/9902#discussion_r567117421
##########
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##########
@@ -239,24 +241,63 @@ public NetworkClient(Selectable selector,
logContext);
}
- private NetworkClient(MetadataUpdater metadataUpdater,
- Metadata metadata,
- Selectable selector,
- String clientId,
- int maxInFlightRequestsPerConnection,
- long reconnectBackoffMs,
- long reconnectBackoffMax,
- int socketSendBuffer,
- int socketReceiveBuffer,
- int defaultRequestTimeoutMs,
- long connectionSetupTimeoutMs,
- long connectionSetupTimeoutMaxMs,
- ClientDnsLookup clientDnsLookup,
- Time time,
- boolean discoverBrokerVersions,
- ApiVersions apiVersions,
- Sensor throttleTimeSensor,
- LogContext logContext) {
+ public NetworkClient(MetadataUpdater metadataUpdater,
Review comment:
Good call, fixed. These are also weirdly inconsistent (`selector` is
before `metadata` and `metadataUpdater` sometimes, after them other times),
which I guess we could clean up, but I didn't want to remove any existing
public constructors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
