aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566394059
########## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ########## @@ -99,7 +99,7 @@ public final InetSocketAddress address; public InetAddressSpec(InetSocketAddress address) { - if (address.equals(NON_ROUTABLE_ADDRESS)) { + if (address != null && address.equals(NON_ROUTABLE_ADDRESS)) { Review comment: Yea, I thought of that. But would there ever be a case where we'd need to construct the address spec with a null? Probably not. Might as well use a nullptr for the address spec at that point I guess. Fair enough, will change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org