rajinisivaram commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r565615638
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -1223,7 +1251,7 @@ class KafkaApis(val requestChannel: RequestChannel,
Set.empty[MetadataResponseTopic]
else
unauthorizedForDescribeTopics.map(topic =>
- metadataResponseTopic(Errors.TOPIC_AUTHORIZATION_FAILED, topic,
false, util.Collections.emptyList()))
+ metadataResponseTopic(Errors.TOPIC_AUTHORIZATION_FAILED, topic,
Uuid.ZERO_UUID, false, util.Collections.emptyList()))
Review comment:
Good point. If not authorized for describe when using topic ids, we need
to make sure we don't return the topic or information about existence of a
topic - i.e we can't return TOPIC_AUTHORIZATION_FAILED. Perhaps
UNKNOWN_TOPIC_ID would be more suitable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
