[GitHub] [kafka] hachikuji commented on a change in pull request #9967: KAFKA-12236; New meta.properties logic for KIP-500

[GitBox]

hachikuji commented on a change in pull request #9967:
URL: https://github.com/apache/kafka/pull/9967#discussion_r565019178



##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1495,6 +1517,13 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: 
Boolean, dynamicConfigO
     distinctRoles
   }
 
+  def metadataLogDir: String = {
+    Option(getString(KafkaConfig.MetadataLogDirProp)) match {
+      case Some(dir) => dir
+      case None => logDirs.head

Review comment:
       Good question. I think the implementation will have to be smart enough 
to find the metadata log dir. Let me see if it is straightforward to add that 
here or if we should leave it for a follow-up. I guess the alternative would be 
to require `metadata.log.dir`, but I think we were trying to avoid that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org