guozhangwang commented on pull request #9836: URL: https://github.com/apache/kafka/pull/9836#issuecomment-765738281
Yup, I think we are on the same page for: 1) `ConsumerRecords#isEmpty`: I was not pointing that it may not return true even if only metadata changed, I meant that if users do not have the `records.isEmpty` condition before the processing logic, then they may waste some more cycles now. 2) Users should not expect that `consumer.poll` always returns non-zero records: that is also true. Like I said, I'm just thinking if it is a paranoid thought for a rare case. For `M v.s. N`, I think you're right that, even with different consumer's min.byte and max.wait configurations, the difference should be small if any. So all clear on my side. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
