dajac commented on a change in pull request #9945:
URL: https://github.com/apache/kafka/pull/9945#discussion_r561957390



##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -1246,13 +1246,15 @@ class KafkaApis(val requestChannel: RequestChannel,
       }
 
     var clusterAuthorizedOperations = Int.MinValue

Review comment:
       `-2147483648` is actually `Int.MinValue`. It would cause an error if we 
would write something different from the default value for versions < 8 and > 
10. 

##########
File path: clients/src/main/resources/common/message/MetadataRequest.json
##########
@@ -31,7 +31,10 @@
     // Starting in version 8, authorized operations can be requested for 
cluster and topic resource.
     //
     // Version 9 is the first flexible version.
-    // Version 10 add topicId
+    //
+    // Version 10 adds topicId.
+    //
+    // Version 11 deprecates IncludeClusterAuthorizedOperations field 
(KIP-700).

Review comment:
       Yeah, why not. I will add it.

##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -1246,13 +1246,15 @@ class KafkaApis(val requestChannel: RequestChannel,
       }
 
     var clusterAuthorizedOperations = Int.MinValue

Review comment:
       Will do.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to