chia7712 commented on a change in pull request #9930:
URL: https://github.com/apache/kafka/pull/9930#discussion_r561021090
##########
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/test/TestRecordTest.java
##########
@@ -166,6 +166,9 @@ public void testProducerRecord() {
final TestRecord<String, Integer> testRecord = new
TestRecord<>(producerRecord);
final TestRecord<String, Integer> expectedRecord = new
TestRecord<>(key, value, headers, recordTime);
assertEquals(expectedRecord, testRecord);
- assertNotEquals(expectedRecord, producerRecord);
+ assertFalse(expectedRecord.getHeaders() == producerRecord.headers() &&
Review comment:
Is the assert intentional? If so, we should keep it and then add clear
comments to avoid confusing readers in the future.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]