dongjinleekr commented on a change in pull request #9930:
URL: https://github.com/apache/kafka/pull/9930#discussion_r560662572
##########
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/test/TestRecordTest.java
##########
@@ -166,6 +166,9 @@ public void testProducerRecord() {
final TestRecord<String, Integer> testRecord = new
TestRecord<>(producerRecord);
final TestRecord<String, Integer> expectedRecord = new
TestRecord<>(key, value, headers, recordTime);
assertEquals(expectedRecord, testRecord);
- assertNotEquals(expectedRecord, producerRecord);
+ assertFalse(expectedRecord.getHeaders() == producerRecord.headers() &&
Review comment:
@chia7712 Sorry for the confusion. Since `expectedRecord` is logically
identical to `testRecord` and `producerRecord` is created fro `testRecord`,
`expectedRecord` and `testRecord` are logically equal. The reason why the
previous assertion was always true was not for its logical state, but the
difference between their classes - `ProducerRecord` vs. `TestRecord`.
So, after some thought, I concluded that just removing the meaningless
assertion is enough. Here is the update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
