jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557034695
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -106,6 +106,7 @@ case class LogAppendInfo(var firstOffset: Option[Long],
var logAppendTime: Long,
var logStartOffset: Long,
var recordConversionStats: RecordConversionStats,
+ var rolled: Boolean,
Review comment:
I implemented this suggestion instead of using `rolled`. We discuss this
offline and is it documented in the code. The caveat in the implementation is
that the segment's base offset and relative offset in the segment is unknown
when the appended records are duplicates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
