ableegoldman commented on a change in pull request #9640:
URL: https://github.com/apache/kafka/pull/9640#discussion_r556929183
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java
##########
@@ -53,16 +56,17 @@
private final Map<TopicPartition, String> ownedPartitions = new
TreeMap<>(TOPIC_PARTITION_COMPARATOR);
private final Map<String, Set<TaskId>> consumerToPreviousStatefulTaskIds =
new TreeMap<>();
- // the following four maps are used only for logging purposes;
- // TODO KAFKA-10283: we could consider merging them with other
book-keeping maps at client-levels
- // so that they would not be inconsistent
Review comment:
I think maybe @guozhangwang and I haven't really explained the purpose
of this cleanup ticket very well...it's Guozhang's ticket so I'll let him
correct me if I've misunderstood the ticket as well, but my impression was that
we wanted to consolidate the client-level sets -- eg `activeTasks` or
`prevActiveTasks`, on lines 46-49 in the current code -- with the
consumer-level maps, eg `consumerToPrevActiveTaskIds`. So the point is not so
much to combine any of the maps on lines 59 - 62, but instead to combine each
map with its corresponding set in the ones on lines 46 - 49. Does that make
sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
