vitojeng commented on pull request #9821:
URL: https://github.com/apache/kafka/pull/9821#issuecomment-759257489


   > I cannot remember the details of the KIP but should we throw this new 
exception also for `allMetadataForStore` and `queryMetadataForKey`?
   
   @mjsax In the KIP-216, we talk about all sub types of 
InvalidStateStoreException. That means this KIP only focus on the existing code 
that throws InvalidStateStoreException, IMHO. Seems there not have any 
InvalidStateStoreException thrown in the `allMetadataForStore` and 
`queryMetadataForKey`. So we didn't discuss whether we should throw this 
exception(UnknownStateStoreException) in the past.
   
   It looks like it will break the API for the new exception. If the answer is 
'Yes', should we need another KIP? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to