dengziming commented on a change in pull request #9807:
URL: https://github.com/apache/kafka/pull/9807#discussion_r552758240
##########
File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
##########
@@ -1250,38 +1252,36 @@ object ReassignPartitionsCommand extends Logging {
* Calculate the global map of all partitions that are moving.
*
* @param currentReassignments The currently active reassignments.
- * @param proposedReassignments The proposed reassignments (destinations
replicas only).
+ * @param proposedParts The proposed location of the partitions
(destinations replicas only).
* @param currentParts The current location of the partitions
that we are
* proposing to move.
* @return A map from topic name to partition map.
* The partition map is keyed on partition
index and contains
* the movements for that partition.
*/
def calculateProposedMoveMap(currentReassignments: Map[TopicPartition,
PartitionReassignment],
Review comment:
Thank you @hachikuji , I also spend much time making sense of this logic
since it's unnecessarily complicated and I tried to solve the issue with the
least code change, which made it even much more untidy. Now I have rewritten
the code according to your suggestions and have simplified it tremendously,
PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
