showuon commented on a change in pull request #9792:
URL: https://github.com/apache/kafka/pull/9792#discussion_r550408203
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -658,6 +658,10 @@ public void handle(JoinGroupResponse joinResponse,
RequestFuture<ByteBuffer> fut
AbstractCoordinator.this.generation = new
Generation(OffsetCommitRequest.DEFAULT_GENERATION_ID, memberId, null);
}
future.raise(error);
+ } else if (error == Errors.REBALANCE_IN_PROGRESS) {
+ log.info("JoinGroup failed due to the group began another
rebalance. Need to re-join the group.");
+ requestRejoin();
Review comment:
You're correct. Removed. Thanks.
##########
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java
##########
@@ -823,6 +823,24 @@ public void
testJoinGroupRequestWithGroupInstanceIdNotFound() {
assertTrue(coordinator.hasUnknownGeneration());
}
+ @Test
+ public void testJoinGroupRequestWithRebalanceInProgress() {
+ setupCoordinator();
+ mockClient.prepareResponse(groupCoordinatorResponse(node,
Errors.NONE));
+ coordinator.ensureCoordinatorReady(mockTime.timer(0));
+
+ mockClient.prepareResponse(
+ joinGroupFollowerResponse(defaultGeneration, memberId,
JoinGroupRequest.UNKNOWN_MEMBER_ID, Errors.REBALANCE_IN_PROGRESS));
+
+ RequestFuture<ByteBuffer> future = coordinator.sendJoinGroupRequest();
+
+ assertTrue(consumerClient.poll(future,
mockTime.timer(REQUEST_TIMEOUT_MS)));
+
assertTrue(future.exception().getClass().isInstance(Errors.REBALANCE_IN_PROGRESS.exception()));
+ assertEquals(Errors.REBALANCE_IN_PROGRESS.message(),
future.exception().getMessage());
+ // should request rejoin
+ assertTrue(coordinator.rejoinNeededOrPending());
Review comment:
Added. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
