mjsax commented on a change in pull request #9801:
URL: https://github.com/apache/kafka/pull/9801#discussion_r550342638
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##########
@@ -124,11 +124,6 @@ public StateStore getStore(final String name) {
return stateMgr.getStore(name);
}
- @Override
- public boolean isClosed() {
Review comment:
This method is unused. Removing it.
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##########
@@ -154,7 +149,7 @@ final void transitionTo(final Task.State newState) {
}
@Override
- public void update(final Set<TopicPartition> topicPartitions, final
Map<String, List<String>> allTopologyNodesToSourceTopics) {
+ public void updateInputPartitions(final Set<TopicPartition>
topicPartitions, final Map<String, List<String>>
allTopologyNodesToSourceTopics) {
Review comment:
Renaming to get better name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
