mjsax commented on a change in pull request #9720:
URL: https://github.com/apache/kafka/pull/9720#discussion_r547567518
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java
##########
@@ -128,8 +128,8 @@ public void shouldShutdownThreadUsingOldHandler() throws
InterruptedException {
TestUtils.waitForCondition(() -> counter.get() == 1, "Handler was
called 1st time");
// should call the UncaughtExceptionHandler after rebalancing to
another thread
TestUtils.waitForCondition(() -> counter.get() == 2,
DEFAULT_DURATION.toMillis(), "Handler was called 2nd time");
- // the stream should now turn into ERROR state after 2 threads are
dead
- waitForApplicationState(Collections.singletonList(kafkaStreams),
KafkaStreams.State.ERROR, DEFAULT_DURATION);
+ // there is no threads running but the client is still in running
+ waitForApplicationState(Collections.singletonList(kafkaStreams),
KafkaStreams.State.RUNNING, DEFAULT_DURATION);
Review comment:
Should we add a metric check to verify that the thread count is zero?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
