mjsax commented on a change in pull request #9733:
URL: https://github.com/apache/kafka/pull/9733#discussion_r547542884
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java
##########
@@ -135,8 +137,13 @@
private final static String CONSUMER_GROUP_ID = "readCommitted";
private final static String MULTI_PARTITION_INPUT_TOPIC =
"multiPartitionInputTopic";
private final static String MULTI_PARTITION_OUTPUT_TOPIC =
"multiPartitionOutputTopic";
+ private final static String APP_DIR_1 = "appDir1";
+ private final static String APP_DIR_2 = "appDir2";
+ private final static String UNEXPECTED_EXCEPTION_MSG = "Fail the test
since we got an unexpected exception or" +
+ "there are too many exceptions thrown, please check standard error log
for more info.";
Review comment:
nit: missing space between `or` (line above) and `there`
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java
##########
@@ -147,9 +154,16 @@
private final AtomicInteger commitCounterClient2 = new AtomicInteger(-1);
private final AtomicInteger commitRequested = new AtomicInteger(0);
- private Throwable uncaughtException;
-
private int testNumber = 0;
+ private boolean hasUnexpectedError = false;
Review comment:
This variable should be declare `volatile` because the callback is
executed on a different thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
