chia7712 commented on pull request #9689: URL: https://github.com/apache/kafka/pull/9689#issuecomment-747370407
> Assuming that we can it make feel more natural with the suggested improvement, do you believe that we should try to continue on trying to use the auto-generate requests and responses directly? I'm +1000 to @dajac as there is a great benefit from using auto-generated code. 1. avoid extra conversion 2. remove duplicate code from code base 3. builder pattern (it is especially good to the classes having a bunch of fields) Also, it is ok to use extra request/response wrap to offer some helper methods when they are NOT supported by auto-generated code (optional and TopicPartition, for example). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
