feyman2016 commented on a change in pull request #9739:
URL: https://github.com/apache/kafka/pull/9739#discussion_r541944104
##########
File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala
##########
@@ -599,12 +599,12 @@ class LogCleanerTest {
val log = makeLog(config = LogConfig.fromProps(logConfig.originals,
logProps))
val appendFirstTransaction = appendTransactionalAsLeader(log, producerId,
producerEpoch,
- origin = AppendOrigin.Replication)
+ origin = AppendOrigin.Coordinator)
Review comment:
Since now for `AppendOrigin.Replication`, the `LogValidator` is bypassed
when `Log.appendAsLeader` is called, which has an assumption that the records
to be appended should have leader epoch ready in its underlying batches. And
moreover, the transaction/group coordinator are supposed to be calling the
`Log.appendAsLeader` with `origin = AppendOrigin.Coordinator`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
