mumrah commented on a change in pull request #9693:
URL: https://github.com/apache/kafka/pull/9693#discussion_r538342108
##########
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##########
@@ -35,8 +36,12 @@ import scala.collection.mutable.ListBuffer
import scala.jdk.CollectionConverters._
/**
- * Handles the sending of AlterIsr requests to the controller. Updating the
ISR is an asynchronous operation,
- * so partitions will learn about updates through LeaderAndIsr messages sent
from the controller
+ * Handles updating the ISR by sending AlterIsr requests to the controller (as
of 2.7) or by updating ZK directly
+ * (prior to 2.7). Updating the ISR is an asynchronous operation, so
partitions will learn about the result of their
+ * request through a callback.
+ *
+ * Note that ISR state changes can still be initiated by the controller and
sent to the partitions via LeaderAndIsr
+ * requests.
*/
trait AlterIsrManager {
Review comment:
I wonder if we should rename this IsrManager now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
