vvcephei commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-706474125
Thanks, @thake . Ah, sorry about that: it was my change, and now I feel extra guilty for not reviewing and merging your fix in a timely fashion. It was intentional not to link those two interfaces with a supertype. I assume that the duplication you're concerned about is in WrappingNullables? I wonder if you can avoid passing in the context to those utility methods and only pass in the `contextKeySerializer`, etc. You could simply getting these at the call site by adding some more extractors to ProcessorContextUtils. Since this was my fault to begin with, I'm also happy to take a crack at it next week if it proves to be a pain. For what it's worth, I quite like your approach in this PR. Thanks again, -John ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
