rondagostino commented on a change in pull request #9378:
URL: https://github.com/apache/kafka/pull/9378#discussion_r500465547
##########
File path: tests/kafkatest/services/kafka/kafka.py
##########
@@ -451,7 +451,8 @@ def _kafka_topics_cmd(self, node, force_use_zk_connection):
set. If Admin client is not going to be used, don't set the
environment variable.
"""
kafka_topic_script = self.path.script("kafka-topics.sh", node)
- skip_security_settings = force_use_zk_connection or not
self.all_nodes_topic_command_supports_bootstrap_server()
+ skip_security_settings = force_use_zk_connection or not
self.all_nodes_topic_command_supports_bootstrap_server() \
+ or self.interbroker_security_protocol ==
SecurityConfig.PLAINTEXT
Review comment:
Yes, good point, I think it would be a helpful to consolidate the
assumptions into one method (or a couple or a few, at most). I'll see what I
can do about refactoring those assumptions out and reusing the logic instead of
having it sprinkled around so much as it is now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
