mjsax commented on a change in pull request #9368:
URL: https://github.com/apache/kafka/pull/9368#discussion_r499105740
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##########
@@ -137,4 +146,48 @@ public void update(final Set<TopicPartition>
topicPartitions, final Map<String,
this.inputPartitions = topicPartitions;
topology.updateSourceTopics(nodeToSourceTopics);
}
+
+ @Override
+ public void maybeInitTaskTimeoutOrThrow(final long currentWallClockMs,
+ final TimeoutException
timeoutException,
+ final Logger log) throws
StreamsException {
+ if (deadlineMs == NO_DEADLINE) {
+ deadlineMs = currentWallClockMs + taskTimeoutMs;
+ } else if (currentWallClockMs > deadlineMs) {
+ final String errorMessage = String.format(
+ "Task %s did not make progress within %d ms. Adjust `%s` if
needed.",
+ id,
+ currentWallClockMs - deadlineMs + taskTimeoutMs,
+ StreamsConfig.TASK_TIMEOUT_MS_CONFIG
+ );
+
+ if (timeoutException != null) {
Review comment:
I added this, as for `poll()` we would not get a `TimeoutException` atm
(even if I hold off to tackle poll() already)
We could also change this and assume that `timeoutException` is never `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
