vvcephei commented on a change in pull request #9361: URL: https://github.com/apache/kafka/pull/9361#discussion_r498591964
########## File path: streams/src/main/java/org/apache/kafka/streams/processor/api/Record.java ########## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.processor.api; + +import org.apache.kafka.common.header.Headers; +import org.apache.kafka.common.header.internals.RecordHeaders; +import org.apache.kafka.streams.errors.StreamsException; + +/** + * A data class representing an incoming record for processing in a {@link Processor} + * or a record to forward to downstream processors via {@link ProcessorContext}. + * + * This class encapsulates all the data attributes of a record: the key and value, but + * also the timestamp of the record and any record headers. + * + * This class is immutable, though the objects referenced in the attributes of this class + * may themselves be mutable. + * + * @param <K> The type of the key + * @param <V> The type of the value + */ +public class Record<K, V> { + private final K key; + private final V value; + private final long timestamp; + private final Headers headers; + + /** + * The full constructor, specifying all the attributes of the record. + * + * @param key The key of the record. May be null. + * @param value The value of the record. May be null. + * @param timestamp The timestamp of the record. May not be negative. + * @param headers The headers of the record. May be null, which will cause subsequent calls + * to {@link this#headers()} to return a non-null, empty, {@link Headers} collection. + * + * @throws IllegalArgumentException if the timestamp is negative. + */ + public Record(final K key, final V value, final long timestamp, final Headers headers) { + this.key = key; + this.value = value; + if (timestamp < 0) { + throw new StreamsException( + "Malformed Record", + new IllegalArgumentException("Timestamp may not be negative. Got: " + timestamp) + ); + } + this.timestamp = timestamp; + this.headers = new RecordHeaders(headers); Review comment: Thanks. I like the idea of putting it in forward. Maybe with a short mention here as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
