mimaison commented on a change in pull request #8730:
URL: https://github.com/apache/kafka/pull/8730#discussion_r498123333
##########
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##########
@@ -429,4 +489,69 @@ private void deleteAllTopics(EmbeddedKafkaCluster cluster)
{
} catch (Throwable e) {
}
}
+
+ private void produceMessages(EmbeddedConnectCluster cluster, String
topicName, String msgPrefix) {
+ produceMessages(cluster, topicName, msgPrefix, null);
Review comment:
I wonder if we should pass `NUM_PARTITIONS` instead of `null` for the
last argument. Then `numPartitions` can be an `int` in the other
`produceMessages()` method. WDYT?
##########
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##########
@@ -381,45 +440,46 @@ public void testOneWayReplicationWithAutoOffsetSync()
throws InterruptedExceptio
waitUntilMirrorMakerIsRunning(backup, mm2Config, "primary", "backup");
- // create a consumer at backup cluster with same consumer group Id to
consume 1 topic
- Consumer<byte[], byte[]> consumer =
backup.kafka().createConsumerAndSubscribeTo(
- Collections.singletonMap("group.id", "consumer-group-1"),
"primary.test-topic-1");
+ // Map<TopicPartition, OffsetAndMetadata> offsets =
Review comment:
Is this left over from debugging?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
