kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r497257420
##########
File path: core/src/main/scala/kafka/server/FinalizedFeatureCache.scala
##########
@@ -20,26 +20,31 @@ package kafka.server
import kafka.utils.Logging
import org.apache.kafka.common.feature.{Features, FinalizedVersionRange}
+import scala.concurrent.TimeoutException
+import scala.math.max
+
// Raised whenever there was an error in updating the FinalizedFeatureCache
with features.
class FeatureCacheUpdateException(message: String) extends
RuntimeException(message) {
}
// Helper class that represents finalized features along with an epoch value.
-case class FinalizedFeaturesAndEpoch(features:
Features[FinalizedVersionRange], epoch: Int) {
+case class FinalizedFeaturesAndEpoch(features:
Features[FinalizedVersionRange], epoch: Long) {
Review comment:
We would like to avoid overflow issues once ZK is gone in the future.
This change is being done based on Colin's suggestion in the KIP-584 voting
thread:
-
[Here](https://lists.apache.org/thread.html/r0dddbe01e2d6991310006b90aa5c9db011461f516f345f621c1f8171%40%3Cdev.kafka.apache.org%3E)
is Colin's comment
-
[Here](https://lists.apache.org/thread.html/rf7fb6a033638c43a338be5cc316e9e69df6e2589fab66b69d8b67f0f%40%3Cdev.kafka.apache.org%3E)
is my response
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
