dajac commented on a change in pull request #9344:
URL: https://github.com/apache/kafka/pull/9344#discussion_r496645598



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##########
@@ -1554,6 +1575,13 @@ private ConfigEntry configEntry(CreatableTopicConfigs 
config) {
 
             @Override
             void handleFailure(Throwable throwable) {
+                // If there were any topics retries due to a quota exceeded 
exception, we propagate
+                // the initial error back to the caller if the request timed 
out.
+                if (options.shouldRetryOnQuotaViolation() && throwable 
instanceof TimeoutException) {
+                    completeQuotaExceededException(futures, 
quotaExceededExceptions,

Review comment:
       That's a very good suggestion, thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to