showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486267744



##########
File path: core/src/main/scala/kafka/server/checkpoints/CheckpointFile.scala
##########
@@ -75,6 +75,17 @@ class CheckpointReadBuffer[T](location: String,
   }
 }
 
+/**
+ * This class interacts with the checkpoint file to read or write 
[TopicPartition, Offset] entries
+ *
+ * The format in the checkpoint file is like this:
+ *  -----checkpoint file content------
+ *  0                <- OffsetCheckpointFile.currentVersion
+ *  2                <- following entries size
+ *  tp1  par1  1     <- the format is: TOPIC  PARTITION  OFFSET
+ *  tp1  par2  2
+ *  -----checkpoint file end----------
+ */

Review comment:
       Thanks for reminding! I've moved my comments to `OffsetCheckpointFile`. 
And add some format comments in `LeaderEpochCheckpointFile`. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to