brary commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r484028797
##########
File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java
##########
@@ -1271,4 +1274,35 @@ private static byte checkRange(final byte i) {
}
return map;
}
+
+
+ /**
+ * Convert a ISO8601 based TimeStamp to Epoch Value
Review comment:
Few nitpicks here:
Convert an ISO8601 based timestamp to an epoch value
....
@return epoch value of a given timestamp
@throws ParseException for timestamp that doesn't follow ISO8601 format
##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -42,13 +42,13 @@
import java.io.IOException;
import java.text.ParseException;
-import java.text.SimpleDateFormat;
+
import java.time.Duration;
import java.time.Instant;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
-import java.util.Date;
+
Review comment:
nit: Please remove this line new line.
##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -42,13 +42,13 @@
import java.io.IOException;
import java.text.ParseException;
-import java.text.SimpleDateFormat;
+
Review comment:
nit: Please remove this line new line.
##########
File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala
##########
@@ -17,7 +17,7 @@
package kafka.admin
-import java.text.{ParseException, SimpleDateFormat}
+
Review comment:
nit: Please remove this line new line.
##########
File path:
streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java
##########
@@ -30,11 +30,10 @@
import org.junit.Before;
import org.junit.Test;
-import java.text.ParseException;
-import java.text.SimpleDateFormat;
+
import java.time.Duration;
import java.util.Collections;
-import java.util.Date;
+
Review comment:
nit: Please remove this line new line.
##########
File path:
streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java
##########
@@ -43,7 +42,7 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
+
Review comment:
nit: Please remove this line new line.
##########
File path:
streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java
##########
@@ -30,11 +30,10 @@
import org.junit.Before;
import org.junit.Test;
-import java.text.ParseException;
-import java.text.SimpleDateFormat;
+
Review comment:
nit: Please remove this line new line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
