vvcephei commented on a change in pull request #8955:
URL: https://github.com/apache/kafka/pull/8955#discussion_r481444344
##########
File path:
streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/serialization/Serdes.scala
##########
@@ -43,12 +43,6 @@ object Serdes extends LowPrioritySerdes {
implicit def javaIntegerSerde: Serde[java.lang.Integer] = JSerdes.Integer()
implicit def uuidSerde: Serde[UUID] = JSerdes.UUID()
- implicit def timeWindowedSerde[T](implicit tSerde: Serde[T]):
WindowedSerdes.TimeWindowedSerde[T] =
- new WindowedSerdes.TimeWindowedSerde[T](tSerde)
-
- implicit def sessionWindowedSerde[T](implicit tSerde: Serde[T]):
WindowedSerdes.SessionWindowedSerde[T] =
- new WindowedSerdes.SessionWindowedSerde[T](tSerde)
Review comment:
Adding it back will also unblock the build, which fails right now
because `WindowedSerdes` is an unused import. I'll just add this back and push
to your branch, assuming the rest of the tests pass, so I can go ahead and
merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
