lct45 commented on a change in pull request #9157:
URL: https://github.com/apache/kafka/pull/9157#discussion_r477380346
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##########
@@ -148,7 +153,7 @@ public void processInOrder(final K key, final V value,
final long timestamp) {
boolean rightWinAlreadyCreated = false;
// keep the left type window closest to the record
- Window latestLeftTypeWindow = null;
+ KeyValue<Windowed<K>, ValueAndTimestamp<Agg>> latestLeftTypeWindow
= null;
try (
final KeyValueIterator<Windowed<K>,
ValueAndTimestamp<Agg>> iterator = windowStore.fetch(
Review comment:
Ah yeah the different types of stores is a good point, I haven't tested
with all of them. I changed it to do 0 or the positive fetch start
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
