[
https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Esteban Quilcate Otoya updated KAFKA-10409:
-------------------------------------------------
Description:
>From [https://github.com/apache/kafka/pull/9137#discussion_r470345513] :
[~ableegoldman] :
> Kind of unrelated, but WDYT about renaming {{RocksDBDualCFIterator}} to
> {{RocksDBDualCFAllIterator}} or something on the side? I feel like these
> iterators could be cleaned up a bit in general to be more understandable –
> for example, it's weird that we do the {{iterator#seek}}-ing in the actual
> {{all()}} method but for range queries we do the seeking inside the iterator
> constructor.
and [https://github.com/apache/kafka/pull/9137#discussion_r470361726] :
> Personally I found the {{RocksDBDualCFIterator}} logic a bit difficult to
> follow even before the reverse iteration, so it would be nice to have some
> tests specifically covering reverse iterators over multi-column-family
> timestamped stores
was:
>From [https://github.com/apache/kafka/pull/9137#discussion_r470345513] :
[~ableegoldman] :
> Kind of unrelated, but WDYT about renaming {{RocksDBDualCFIterator}} to
> {{RocksDBDualCFAllIterator}} or something on the side? I feel like these
> iterators could be cleaned up a bit in general to be more understandable --
> for example, it's weird that we do the {{iterator#seek}}-ing in the actual
> {{all()}} method but for range queries we do the seeking inside the iterator
> constructor.
> Refactor Kafka Streams RocksDb iterators
> -----------------------------------------
>
> Key: KAFKA-10409
> URL: https://issues.apache.org/jira/browse/KAFKA-10409
> Project: Kafka
> Issue Type: Improvement
> Reporter: Jorge Esteban Quilcate Otoya
> Priority: Minor
>
> From [https://github.com/apache/kafka/pull/9137#discussion_r470345513] :
> [~ableegoldman] :
> > Kind of unrelated, but WDYT about renaming {{RocksDBDualCFIterator}} to
> > {{RocksDBDualCFAllIterator}} or something on the side? I feel like these
> > iterators could be cleaned up a bit in general to be more understandable –
> > for example, it's weird that we do the {{iterator#seek}}-ing in the actual
> > {{all()}} method but for range queries we do the seeking inside the
> > iterator constructor.
> and [https://github.com/apache/kafka/pull/9137#discussion_r470361726] :
> > Personally I found the {{RocksDBDualCFIterator}} logic a bit difficult to
> > follow even before the reverse iteration, so it would be nice to have some
> > tests specifically covering reverse iterators over multi-column-family
> > timestamped stores
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
