abbccdda commented on a change in pull request #9068:
URL: https://github.com/apache/kafka/pull/9068#discussion_r460368003



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##########
@@ -770,12 +770,18 @@ public boolean rejoinNeededOrPending() {
         // we need to rejoin if we performed the assignment and metadata has 
changed;
         // also for those owned-but-no-longer-existed partitions we should 
drop them as lost
         if (assignmentSnapshot != null && 
!assignmentSnapshot.matches(metadataSnapshot)) {
+            log.info("Requesting to re-join the group and trigger rebalance 
since the assignment metadata has changed from {} to {}",
+                    assignmentSnapshot, metadataSnapshot);
+
             requestRejoin();
             return true;
         }
 
         // we need to join if our subscription has changed since the last join
         if (joinedSubscription != null && 
!joinedSubscription.equals(subscriptions.subscription())) {
+            log.info("Requesting to re-join the group and trigger rebalance 
since the subscription has changed from {} to {}",
+                    joinedSubscription, subscriptions.subscription());

Review comment:
       nit: fix alignment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to