mjsax commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r459206315
##########
File path: streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
##########
@@ -186,25 +183,9 @@ public void
consumerConfigMustContainStreamPartitionAssignorConfig() {
);
assertEquals(7L,
returnedProps.get(StreamsConfig.WINDOW_STORE_CHANGE_LOG_ADDITIONAL_RETENTION_MS_CONFIG));
assertEquals("dummy:host",
returnedProps.get(StreamsConfig.APPLICATION_SERVER_CONFIG));
- assertNull(returnedProps.get(StreamsConfig.RETRIES_CONFIG));
- assertEquals(5,
returnedProps.get(StreamsConfig.adminClientPrefix(StreamsConfig.RETRIES_CONFIG)));
assertEquals(100,
returnedProps.get(StreamsConfig.topicPrefix(TopicConfig.SEGMENT_BYTES_CONFIG)));
}
- @SuppressWarnings("deprecation") // TODO revisit in follow up PR
Review comment:
Third TODO removed -- as we don't pass `retires` and `retry.backoff.ms`
via admin config any longer, this test is not needed any more
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
